Changeset 10549

Timestamp:

07/31/08 18:56:38 (4 months ago)

Author:

francois

Message:

sfPropelFinderPlugin Fixed problem with join() and with() when called by children of sfPropelPager (closes #4041)

Files:

• plugins/sfPropelFinderPlugin/README (modified) (1 diff)
• plugins/sfPropelFinderPlugin/lib/sfPropelFinder.php (modified) (1 diff)
• plugins/sfPropelFinderPlugin/test/unit/sfPropelFinderRelationsTest.php (modified) (2 diffs)

plugins/sfPropelFinderPlugin/README

@@ -613 +613 @@
-=== 2008-07-31 | Trunk ===
-
-
+
+
- * mrhyde:   Added `sfPropelFinder::groupByClass()` to ease PostgreSQL grouping
- * francois: Fixed problem with table alias and PostgreSQL (based on a patch by mrhyde)

plugins/sfPropelFinderPlugin/lib/sfPropelFinder.php

@@ -27 +27 @@
-    if($class)
-    {
+      // Instanciation with a class
-      list($class, $alias) = $this->getClassAndAlias($class);
-      $this->class = $class;
-      $tmp = new $class;
-      $this->setPeerClass(get_class($tmp->getPeer()), $alias);
+    }
+    else if($this->peerClass)
+    {
+      // Instanciation for a child of sfPropelFinder
+      $this->addRelation($this->peerClass);
-    }
-    if($this->peerClass)

plugins/sfPropelFinderPlugin/test/unit/sfPropelFinderRelationsTest.php

@@ -79 +79 @@
-$con = Propel::getConnection();
-
-79
+81
-
-$t->diag('findRelation()');
@@ -468 +468 @@
-$article = $finder->findOne();
-$t->is($finder->getLatestQuery(), 'SELECT article.ID, article.TITLE, article.CATEGORY_ID, COUNT(comment.ID) AS NbComments FROM article, comment WHERE article.ID=comment.ARTICLE_ID GROUP BY article.ID ORDER BY NbComments ASC LIMIT 1', 'Columns added with withColumn() can be used for sorting');
+
+$t->diag('sfPropelFinder::with() issues with object finders classes');
+class ArticleFinder extends sfPropelFinder
+{
+  protected $peerClass = 'ArticlePeer';
+}
+
+$finder = new ArticleFinder;
+try
+{
+  $finder->join('Category')->find();
+  $t->pass('Relations lookup work also on finder children objects');
+}
+catch (Exception $e)
+{
+  $t->fail('Relations lookup work also on finder children objects');
+}
+try
+{
+  $finder->with('Category')->find();
+  $t->pass('Relations lookup work also on finder children objects');
+}
+catch (Exception $e)
+{
+  $t->fail('Relations lookup work also on finder children objects');
+}
+