Changeset 7392

Timestamp:

02/07/08 18:52:17 (10 months ago)

Author:

hartym

Message:

sfPropelImpersonatorPlugin: added a check to avoid having orphans objects fetched, will avoid headaches

Files:

• plugins/sfPropelImpersonatorPlugin/trunk/lib/sfPropelObjectPeerImpersonator.class.php (modified) (6 diffs)

plugins/sfPropelImpersonatorPlugin/trunk/lib/sfPropelObjectPeerImpersonator.class.php

@@ -163 +163 @@
-                        'type'         => self::RELATION_I18N,
-                        'classTo'      => $_class_to,
-  
+
-                        'local'        => $c->getPhpName(),
-                        'distant'      => $c->getRelatedTableName(),
@@ -394 +394 @@
-        if ($index/*&&$isNewObject*/)
-        {
+          $linkedRelationsCounter = 0;
+
-          foreach ($this->getRelationsFor($index) as $relation)
-          {
@@ -424 +426 @@
-                $currentObject->{'add'.$foreignClass}($foreignObject);
-                $foreignObject->{'set'.$relation['classTo']}($currentObject);
+
+                $linkedRelationsCounter++;
-                break;
-
@@ -448 +452 @@
-                  $object->{'set'.$relation['classTo'].'I18nForCulture'}($i18nObject, $this->getCulture());
-
+                  $linkedRelationsCounter++;
-                }
-                break;
@@ -477 +482 @@
-                  $foreignObject->{'init'.$relation['classFrom'].'s'}($rowObjects[$index]);
-                  $foreignObject->{'add'.$relation['classFrom']}($rowObjects[$index]);
-
+
+
+
+
+
+
+
-                break;
-            }
@@ -486 +497 @@
-            }
-          }
+
+          if (!$linkedRelationsCounter)
+          {
+            // this should not happen. An object which is not our main object has not been linked to any other
+            // fetched object.
+            throw new sfException('Orphan object fetched of type '.get_class($rowObjects[$index]));
+          }
-        }
-