Changeset 7394

Timestamp:

02/07/08 21:42:52 (10 months ago)

Author:

francois

Message:

Ported sfPropelAlternativeSchemaPlugin features to 1.1 branch:

• Allow a schema to override another one
  
• Allow behavior declaration directly in the schema
  
• Provide an alternative schema syntax, more object-oriented
  

Files:

• branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/builder/SfObjectBuilder.php (modified) (1 diff)
• branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/builder/SfPeerBuilder.php (modified) (1 diff)
• branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/sfPropelDatabaseSchema.class.php (modified) (11 diffs)
• branches/1.1/lib/plugins/sfPropelPlugin/lib/task/sfPropelBaseTask.class.php (modified) (1 diff)
• branches/1.1/lib/plugins/sfPropelPlugin/test/unit/fixtures/new_schema.yml (added)
• branches/1.1/lib/plugins/sfPropelPlugin/test/unit/fixtures/schema.xml (added)
• branches/1.1/lib/plugins/sfPropelPlugin/test/unit/fixtures/schema.yml (modified) (1 diff)
• branches/1.1/lib/plugins/sfPropelPlugin/test/unit/sfPropelDatabaseSchemaTest.php (modified) (2 diffs)

branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/builder/SfObjectBuilder.php

@@ -347 +347 @@
-    $script .= $tmp;
-  }
+  
+  protected function addClassClose(&$script)
+  {
+    parent::addClassClose($script);
+    
+    $behaviors = $this->getTable()->getAttribute('behaviors');
+    if($behaviors)
+    {
+      $behavior_file_name = 'Base'.$this->getTable()->getPhpName().'Behaviors';
+      $behavior_file_path = $this->getFilePath($this->getStubObjectBuilder()->getPackage().'.om.'.$behavior_file_name);
+      $script .= sprintf("\n\ninclude_once '%s';\n", $behavior_file_path);
+    }
+  }
-}

branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/builder/SfPeerBuilder.php

@@ -382 +382 @@
-    $script .= $tmp;
-  }
+  
+  protected function addClassClose(&$script)
+  {
+    parent::addClassClose($script);
+
+    $behavior_file_name = 'Base'.$this->getTable()->getPhpName().'Behaviors';
+    $behavior_file_path = $this->getFilePath($this->getStubObjectBuilder()->getPackage().'.om.'.$behavior_file_name);
+    $absolute_behavior_file_path = sfConfig::get('sf_root_dir').'/'.$behavior_file_path;
+    
+    if(file_exists($absolute_behavior_file_path))
+    {
+      unlink($absolute_behavior_file_path);
+    }
+    
+    $behaviors = $this->getTable()->getAttribute('behaviors');
+    if($behaviors)
+    {
+      file_put_contents($absolute_behavior_file_path, sprintf("<?php\nsfPropelBehavior::add('%s', %s);\n", $this->getTable()->getPhpName(), var_export(unserialize($behaviors), true)));
+      $script .= sprintf("\n\ninclude_once '%s';\n", $behavior_file_path);
+    }
+  }
-}

branches/1.1/lib/plugins/sfPropelPlugin/lib/propel/sfPropelDatabaseSchema.class.php

@@ -3 +3 @@
-/*
- * This file is part of the symfony package.
-
+
+
- *
- * For the full copyright and license information, please view the LICENSE
@@ -27 +28 @@
-  }
-
+  public function loadArray($schema_array)
+  {
+    $database = array();
+    $connection_name = '';
+
+    if (isset($schema_array['classes']))
+    {
+      // New schema syntax
+      $schema_array = $this->convertNewToOldYaml($schema_array);
+    }
+
+    if (count($schema_array) > 1)
+    {
+      throw new sfException('A schema.yml must only contain 1 database entry.');
+    }
+
+    $tmp = array_keys($schema_array);
+    $connection_name = array_shift($tmp);
+
+    if ($connection_name)
+    {
+      $database = $schema_array[$connection_name];
+    }
+
+    $this->connection_name = $connection_name;
+    $this->database = $database;
+    
+    $this->fixYAMLDatabase();
+    $this->fixYAMLI18n();
+    $this->fixYAMLColumns();
+  }
+  
-  public function loadYAML($file)
-  {
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-    $tmp = array_keys($schema);
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-  }
-
@@ -57 +238 @@
-    foreach ($this->getChildren($this->database) as $tb_name => $table)
-    {
-
+
+
+
+
+
+
-
-      // columns
@@ -226 +412 @@
-              'required'      => true,
-              'primaryKey'    => true,
-i
+I
-            );
-            $has_primary_key = true;
@@ -240 +426 @@
-              $this->database[$table][$column] = array(
-                'type'             => 'integer',
-                'required'         => true,
-                'foreignTable'     => $foreign_table,
-,
+
-              );
-            }
-            else
-            {
-
+.
-            }
-          }
+          
-        }
-        else
@@ -280 +466 @@
-          'required'      => true,
-          'primaryKey'    => true,
-i
+I
-        );
-      }
@@ -313 +499 @@
-    foreach ($this->getTables() as $tb_name => $table)
-    {
-
+
+
+
+
+
+
+
+
+
-      {
-        $table_match = $tb_name;
+        break;
-      }
-    }
@@ -329 +524 @@
-      foreach ($column as $key => $value)
-      {
-Table', 'foreignReference', 'onDelete', 'onUpdate', 'index', 'uniqu
+Class', 'foreignTable', 'foreignReference', 'onDelete', 'onUpdate', 'index', 'unique', 'sequenc
-        {
-          $attributes_string .= " $key=\"".htmlspecialchars($this->getCorrectValueFor($key, $value))."\"";
@@ -338 +533 @@
-    else
-    {
-%s
+"%s".
-    }
-
-    // conventions for foreign key attributes
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-      if (isset($column['onDelete']))
-      {
@@ -659 +870 @@
-      foreach ($columns as $column => $attributes)
-      {
-i
+I
-        {
-          // simplify primary keys
@@ -704 +915 @@
-    foreach ($hash as $attribute => $value)
-    {
-strval($value)
+(string) $value
-    }
-

branches/1.1/lib/plugins/sfPropelPlugin/lib/task/sfPropelBaseTask.class.php

@@ -98 +98 @@
-
-    $dbSchema = new sfPropelDatabaseSchema();
+    
-    foreach ($schemas as $schema)
-    {
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-      $this->dispatcher->notify(new sfEvent($this, 'command.log', array($this->formatter->formatSection('schema', sprintf('converting "%s" to XML', $schema)))));

branches/1.1/lib/plugins/sfPropelPlugin/test/unit/fixtures/schema.yml

@@ -1 +1 @@
-propel:
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

branches/1.1/lib/plugins/sfPropelPlugin/test/unit/sfPropelDatabaseSchemaTest.php

@@ -3 +3 @@
-/*
- * This file is part of the symfony package.
-
+
+
- * 
- * For the full copyright and license information, please view the LICENSE
@@ -11 +12 @@
-require_once(dirname(__FILE__).'/../../../../../test/bootstrap/unit.php');
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
+require_once(dirname(__FILE__).'/../../../../../test/bootstrap/unit.php');
+require_once(dirname(__FILE__).'/../../lib/propel/sfPropelDatabaseSchema.class.php');
+require_once(dirname(__FILE__).'/../../../../util/sfInflector.class.php');
+require_once(dirname(__FILE__).'/../../../../util/sfToolkit.class.php');
+require_once(dirname(__FILE__).'/../../../../util/sfYaml.class.php');
+
+$t = new my_lime_test(261, new lime_output_color());
+
+$t->diag('Classical YAML to XML conversion');
-$p = new sfPropelDatabaseSchema();
-$p->loadYAML(dirname(__FILE__).'/fixtures/schema.yml');
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+