Changeset 8664

Timestamp:

04/28/08 22:42:14 (6 months ago)

Author:

FabianLange

Message:

made sfMySQLSessionStorage more robust by using SQL date functions and no longer injecting php timestamps. MySQL Now() works on both DateTime? and TimeStamp? columns ok and using the native date + INTERVAL $lifetime SECONDS possible time troubles are reduced. (fixes #3394)

Files:

• branches/1.0/lib/storage/sfMySQLSessionStorage.class.php (modified) (5 diffs)

branches/1.0/lib/storage/sfMySQLSessionStorage.class.php

@@ -124 +124 @@
-   * Cleans up old sessions.
-   *
-
+ in seconds
-   *
-   * @return boolean true, if old sessions have been cleaned, otherwise an exception is thrown
@@ -132 +132 @@
-  public function sessionGC($lifetime)
-  {
-    // determine deletable session time
-    $time = time() - $lifetime;
-
-    // get table/column
-    $db_table    = $this->getParameterHolder()->get('db_table');
@@ -141 +138 @@
-    // delete the record associated with this id
-    $sql = 'DELETE FROM '.$db_table.' '.
-< '.$time
++ INTERVAL '.$lifetime.' SECOND < NOW()'
-
-    if (@mysql_query($sql, $this->resource))
@@ -217 +214 @@
-      $sql = 'INSERT INTO '.$db_table.' ('.$db_id_col.', ' .
-             $db_data_col.', '.$db_time_col.') VALUES (' .
-'.time().'
+NOW()
-
-      if (@mysql_query($sql, $this->resource))
@@ -257 +254 @@
-    $sql = 'UPDATE '.$db_table.' ' .
-           'SET '.$db_data_col.' = \''.$data.'\', ' .
-'.time().'
+NOW()
-           'WHERE '.$db_id_col.' = \''.$id.'\'';
-