Changeset 8813

Timestamp:

05/06/08 18:05:48 (2 months ago)

Author:

fabien

Message:

added a check for license when install a plugin with the plugin:install task (closes #2316)

Files:

• branches/1.1/lib/plugin/sfPearRestPlugin.class.php (modified) (1 diff)
• branches/1.1/lib/plugin/sfPluginManager.class.php (modified) (1 diff)
• branches/1.1/lib/task/plugin/sfPluginInstallTask.class.php (modified) (2 diffs)

branches/1.1/lib/plugin/sfPearRestPlugin.class.php

@@ -73 +73 @@
-
-  /**
+   * Returns the license for a given plugin and version.
+   *
+   * @param string The plugin name
+   * @param string The version
+   *
+   * @param string The license
+   */
+  public function getPluginLicense($plugin, $version)
+  {
+    $info = $this->packageInfo($this->restBase, $plugin);
+
+    if (is_null($info))
+    {
+      // plugin does not exist
+      return null;
+    }
+
+    if (!isset($info['license']) || is_null($info['license']))
+    {
+      throw new Exception('No license found for this plugin!');
+    }
+
+    return $info['releases'][$version]['license'];
+  }
+
+  /**
-   * Gets the all available versions for a given plugin.
-   *

branches/1.1/lib/plugin/sfPluginManager.class.php

@@ -413 +413 @@
-
-  /**
+   * Returns the license for a given plugin.
+   *
+   * @param string The plugin name
+   * @param array  An array of options
+   *
+   * @param string The license
+   *
+   * @see installPlugin() for available options
+   */
+  public function getPluginLicense($plugin, $options = array())
+  {
+    $channel   = isset($options['channel']) ? $options['channel'] : $this->environment->getConfig()->get('default_channel');
+    $stability = isset($options['stability']) ? $options['stability'] : $this->environment->getConfig()->get('preferred_state', null, $channel);
+    $version   = isset($options['version']) ? $options['version'] : null;
+
+    $rest = $this->environment->getRest();
+    $rest->setChannel(is_null($channel) ? $this->environment->getConfig()->get('default_channel') : $channel);
+
+    if (is_null($version))
+    {
+      $version = $this->getPluginVersion($plugin, $stability);
+    }
+
+    return $rest->getPluginLicense($plugin, $version);
+  }
+
+  /**
-   * Returns true if the plugin is comptatible with the dependency.
-   *

branches/1.1/lib/task/plugin/sfPluginInstallTask.class.php

@@ -35 +35 @@
-      new sfCommandOption('channel', 'c', sfCommandOption::PARAMETER_REQUIRED, 'The PEAR channel name', null),
-      new sfCommandOption('install_deps', 'd', sfCommandOption::PARAMETER_NONE, 'Whether to force installation of required dependencies', null),
+      new sfCommandOption('force-license', null, sfCommandOption::PARAMETER_NONE, 'Whether to force installation even if the license is not MIT like'),
-    ));
-
@@ -102 +103 @@
-    unset($options['release']);
-
+    // license compatible?
+    if (!$options['force-license'])
+    {
+      try
+      {
+        $license = $this->getPluginManager()->getPluginLicense($arguments['name'], isset($options['channel']) ? $options['channel'] : null);
+      }
+      catch (Exception $e)
+      {
+        throw new sfCommandException(sprintf('%s (use --force-license to force installation)', $e->getMessage()));
+      }
+
+      $temp = trim(str_replace('license', '', strtolower($license)));
+      if (!is_null($license) && !in_array($temp, array('mit', 'bsd', 'lgpl', 'php', 'apache')))
+      {
+        throw new sfCommandException(sprintf('The license of this plugin "%s" is not MIT like (use --force-license to force installation).', $license));
+      }
+    }
+
-    $this->getPluginManager()->installPlugin($arguments['name'], $options);
-  }