Development

Changeset 8828

You must first sign up to be able to contribute.

Changeset 8828

Show
Ignore:
Timestamp:
05/07/08 10:41:28 (5 months ago)
Author:
FabianLange
Message:

remote_function will return a complete Javascript statement including the trailing semicolon. Fixes #3135

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • branches/1.1/lib/helper/JavascriptHelper.php

    r8719 r8828  
    275275    $options['form'] = true; 
    276276 
    277     $options_html['onsubmit'] = remote_function($options).'; return false;'; 
     277    $options_html['onsubmit'] = remote_function($options).' return false;'; 
    278278    $options_html['action'] = isset($options_html['action']) ? $options_html['action'] : url_for($options['url']); 
    279279    $options_html['method'] = isset($options_html['method']) ? $options_html['method'] : 'post'; 
    …… 
    297297 
    298298    $options_html['type'] = 'button'; 
    299     $options_html['onclick'] = remote_function($options).'; return false;'; 
     299    $options_html['onclick'] = remote_function($options).' return false;'; 
    300300    $options_html['name'] = $name; 
    301301    $options_html['value'] = $value; 
    …… 
    319319 
    320320    $options_html['type'] = 'image'; 
    321     $options_html['onclick'] = remote_function($options).'; return false;'; 
     321    $options_html['onclick'] = remote_function($options).' return false;'; 
    322322    $options_html['name'] = $name; 
    323323    $options_html['src'] = image_path($source); 
    …… 
    487487    } 
    488488 
    489     return $function; 
     489    return $function.';'; 
    490490  } 
    491491