Development

Changeset 8964

You must first sign up to be able to contribute.

Changeset 8964

Show
Ignore:
Timestamp:
05/14/08 22:14:44 (2 months ago)
Author:
dwhittle
Message:

dwhittle: merged changes to branch

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/dwhittle/1.0/CHANGELOG

    r8800 r8964  
    1 Version 1.0.15PRE 
    2 -------------- 
    3  
    4 This is a bug fix release. 
     1Version 1.0.17PRE 
     2------------- 
     3 
     4This is a bug fix release. 
     5 
     6Version 1.0.16 
     7------------- 
     8 
     9This is a bug fix release. 
     10 
     11* r8922: fixed yml validator file can be overriden by a remote attacker (closes #1617) 
     12 
     13Version 1.0.15 
     14------------- 
     15 
     16This is a bug fix release. 
     17 
     18* r8861: fixed problem with PHP 5.2.6 and ini variables access value (closes #3466 - related to http://bugs.php.net/bug.php?id=44936) 
     19* r8836: fixed some issues with button_to helper (closes #3184) 
     20* r8831: fixed include_remove option not used in ObjectAdminHelper? (closes #2079) 
     21* r8827: remote_function will return a complete Javascript statement including the trailing semicolon. (closes #3135) 
     22* r8825: fixed I18N helper dependency (closes #1794) 
     23* r8823: fixed FCK editor not being populated by fillin filter. (closes #732) 
     24* r8819: corrected ID generation for TinyMCE rich editor when no id was given. (closes #3474) 
    525 
    626Version 1.0.14 
     
    929This is a bug fix release. 
    1030 
    11 * r8763: fixed DateHelper distance_of_time_in_words() generates incorrect output for some dates (closes #3322)  
     31* r8763: fixed DateHelper distance_of_time_in_words() generates incorrect output for some dates (closes #3322) 
    1232* r8754: validation yml with fillin is used even without other validators defined in the file. (closes #3232) 
    1333* r8720: fixed url validation bug by applied carls patch (1.1 backport). (closes #1373) 
    1434* r8718: Add support for "paramName" option to _auto_complete_field() function (closes #2345) 
    15 * r8716: sfFillInForm adds a content-type meta if non present so that dom->loadHTML works correctly. (closes #2653)  
     35* r8716: sfFillInForm adds a content-type meta if non present so that dom->loadHTML works correctly. (closes #2653) 
    1636* r8709: fillin now handles array notations like <input type="text" name "textinput[]"/> correctly. (closes #2811) 
    1737* r8707: fixed ajax response fillin, which does not include a doctype because it is returned without layout. (closes #1687) 
    1838* r8699: added compat options to propel database  (fixes #3364) 
    1939* r8695: made sfFillInForm work with checkbox arrays as well like checkbox_many[]. (closes #1776, #3399) 
    20 * r8664: made sfMySQLSessionStorage more robust by using SQL date functions and no longer injecting php timestamps. (fixes #3394)  
     40* r8664: made sfMySQLSessionStorage more robust by using SQL date functions and no longer injecting php timestamps. (fixes #3394) 
    2141* r8651: corrected checking for Eaccelerator in sfProcessCache. (closes #3425) 
    2242* r8445: fixed web debug toolbar in safari (closes #3328, #1673) 
  • branches/dwhittle/1.0/lib/VERSION

    r8800 r8964  
    1 1.0.15-PRE 
     11.0.17-PRE 
  • branches/dwhittle/1.1/lib/task/generator/sfGenerateTaskTask.class.php

    r8519 r8964  
    6565 
    6666    // Validate the class name 
    67     if (!preg_match('/^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $app)) 
     67    if (!preg_match('/^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $taskClassName)) 
    6868    { 
    69       throw new sfCommandException(sprintf('The task class name "%s" is invalid.', $app)); 
     69      throw new sfCommandException(sprintf('The task class name "%s" is invalid.', $taskClassName)); 
    7070    } 
    7171 
  • branches/dwhittle/1.1/lib/widget/sfWidgetFormSchema.class.php

    r8770 r8964  
    2626    BEFORE = 'before', 
    2727    AFTER  = 'after'; 
     28   
     29  protected static 
     30    $defaultFormatterName = 'table'; 
    2831 
    2932  protected 
     
    6366 
    6467    $this->addOption('name_format', '%s'); 
    65     $this->addOption('form_formatter', 'table'); 
     68    $this->addOption('form_formatter', self::$defaultFormatterName); 
    6669 
    6770    parent::__construct($options, $attributes); 
     
    99102  { 
    100103    return $this->formFormatters; 
     104  } 
     105   
     106  /** 
     107   * Sets the generic default formatter name used by the class. If you want all  
     108   * of your forms to be generated with the <code>list</code> format, you can  
     109   * do it in a project or application configuration class: 
     110   *  
     111   * <pre> 
     112   * class ProjectConfiguration extends sfProjectConfiguration 
     113   * { 
     114   *   public function setup() 
     115   *   { 
     116   *     sfWidgetFormSchema::setDefaultFormFormatterName('list'); 
     117   *   } 
     118   * } 
     119   * </pre>   
     120   * 
     121   * @param string $name 
     122   */ 
     123  static public function setDefaultFormFormatterName($name) 
     124  { 
     125    self::$defaultFormatterName = $name; 
    101126  } 
    102127 
  • branches/dwhittle/1.1/test/unit/widget/sfWidgetFormSchemaTest.php

    r8770 r8964  
    1111require_once(dirname(__FILE__).'/../../bootstrap/unit.php'); 
    1212 
    13 $t = new lime_test(57, new lime_output_color()); 
     13$t = new lime_test(59, new lime_output_color()); 
    1414 
    1515$w1 = new sfWidgetFormInput(array(), array('class' => 'foo1')); 
     
    332332  $t->ok($widget == $f[$name], '__clone() clones embedded widgets'); 
    333333} 
     334 
     335// setDefaultFormFormatterName() 
     336$t->diag('setDefaultFormFormatterName()'); 
     337$w = new sfWidgetFormSchema(array('w1' => $w1, 'w2' => $w2)); 
     338$t->isa_ok($w->getFormFormatter(), 'sfWidgetFormSchemaFormatterTable', 'setDefaultFormFormatterName() has the "sfWidgetFormSchemaFormatterTable" form formatter by default'); 
     339 
     340sfWidgetFormSchema::setDefaultFormFormatterName('list'); 
     341$w = new sfWidgetFormSchema(array('w1' => $w1, 'w2' => $w2)); 
     342$t->isa_ok($w->getFormFormatter(), 'sfWidgetFormSchemaFormatterList', 'setDefaultFormFormatterName() changes the default form formatter name correctly');