Development

#1802 ([PATCH]: Add "xdebug_logging" to settings.yml)

You must first sign up to be able to contribute.

Ticket #1802 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

[PATCH]: Add "xdebug_logging" to settings.yml

Reported by: Emiliano.Gabrielli Assigned to: fabien
Priority: minor Milestone: 1.1.0
Component: logging Version:
Keywords: logging xdebug settings.yml Cc:
Qualification: Ready for core team

Description

This patch makes the developer to enable or not the xdebug logging (if xdebug is present) in the web toolbar.

It makes possible to have some speed enhancement even in dev environment, not requiring sysadmin to disable xdebug on the server

Change History

06/05/07 23:36:41 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

(In [4163]) dwhittle: applying patches for xdebug setting.yml switch + extension versions in php info, closes #1802, #1690

06/05/07 23:44:34 changed by dwhittle

  • status changed from closed to reopened.
  • resolution deleted.

not committed to trunk...

06/06/07 09:49:18 changed by Emiliano.Gabrielli

  • cc deleted.

Plz note that the changes you made in your changeset is very different from the proposed. I'll try to explain my point:

  • xdebug is enabled or not as the system administrator want... AFIK we can't disable the extension runtime (and your changes do not)
  • we can disable the logging using xdebug
  • my patch leaves unchanged the *xdebug* enabled/disable "led" in the weblog toolbar, *adding* the capability for the programmer to:
    • enable/disable the addition of xdebug infos to logging
    • view the status of this setting in the weblog toolbar (if and only if the xdebug extension is enabled too)

I think this approach is good (otherwise I'll have proposed another one of course), so I'm tring to show my reasons :-)

Thank you for your comments about it

06/06/07 19:39:45 changed by dwhittle

Emiliano,

I don't think it is that different, the only real difference is I don't have xdebug_logigng in the debug toolbar. Having both is redundant as they serve the same purpose, if you would not like to have all the extra xdebug output you can simply disable in the config file. If you just want to check that the extension is present open the setting in debug toolbar and click on php.

Ultimately, the only real way to remove the xdebug is to disable in php.ini or remove extension. This provides a switch to enable or disable the extra xdebug logs (which is the only way symfony utilizes xdebug; for additonal log info)...

Does this work for you?

10/01/07 08:24:50 changed by dwhittle

  • qualification set to Ready for core team.

11/04/07 16:29:11 changed by fabien

  • milestone changed from post-1.0 to 1.1.0.

11/04/07 16:36:11 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5844]) added a new xdebug_logging parameter to sfWebDebugLogger - this parameter is true by default (closes #1802)