Development

#1827 ([PATCH] sfViewConfigHandler::addHtmlHead($viewName = '') converts non-ascii symbols to entities)

You must first sign up to be able to contribute.

Ticket #1827 (closed defect: fixed)

Opened 1 year ago

Last modified 6 months ago

[PATCH] sfViewConfigHandler::addHtmlHead($viewName = '') converts non-ascii symbols to entities

Reported by: Pavel.Treutner Assigned to: fabien
Priority: major Milestone: 1.1.0
Component: configuration Version: 1.0.7
Keywords: Cc:
Qualification: Design decision

Description

Would it be possible to use htmlspecialchars() instead of htmlentities() in sfViewConfigHandler::addHtmlHead($viewName = '')? All non-ascii symbols are converted to html entities now. See #401.

Attachments

symfony-1.0.7-htmlentities-patch (3.4 kB) - added by Pavel.Treutner on 09/24/07 14:08:20.
rev-5940-htmlentities.patch (3.2 kB) - added by Pavel.Treutner on 11/09/07 18:50:01.
new patch against revision 5940

Change History

07/02/07 11:16:37 changed by Pavel.Treutner

  • version set to 1.0.5.

07/25/07 21:21:42 changed by Rihad.Haciyev

  • priority changed from minor to major.

09/24/07 14:08:20 changed by Pavel.Treutner

  • attachment symfony-1.0.7-htmlentities-patch added.

09/24/07 14:09:22 changed by Pavel.Treutner

  • version changed from 1.0.5 to 1.0.7.
  • qualification set to Unreviewed.
  • summary changed from sfViewConfigHandler::addHtmlHead($viewName = '') converts non-ascii symbols to entities to [PATCH] sfViewConfigHandler::addHtmlHead($viewName = '') converts non-ascii symbols to entities.

11/09/07 18:50:01 changed by Pavel.Treutner

  • attachment rev-5940-htmlentities.patch added.

new patch against revision 5940

04/04/08 19:18:09 changed by FabianLange

  • qualification set to Design decision.

Fabien? you have recently worked on escaping, havent you? Do you think this can be safely added to 1.0 or should this be done only for 1.1?

04/04/08 19:35:00 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 1.1.0.

This is fixed in 1.1 as we now use htmlspecialchars by default. Won't be fixed in 1.0.