Development

#2082 ([sfCombineFilterPlugin][PATCH] problem with getCombinedStylesheets)

You must first sign up to be able to contribute.

Ticket #2082 (new defect)

Opened 1 year ago

Last modified 10 months ago

[sfCombineFilterPlugin][PATCH] problem with getCombinedStylesheets

Reported by: Joel.Alexandre Assigned to: smeves
Priority: major Milestone: plugins
Component: sfCombineFilterPlugin Version:
Keywords: Cc:
Qualification: Unreviewed

Description

hi,

i was trying the sfCombineFilter plugin and i found a bug in the getCombinedStylesheets method that didn't allow the css packed to work.

The getCombinedStylesheets returns

/css/packed//css/cpanel.css,/css/layout2.css,/css/default.css

and it should be

/css/packed/cpanel.css,layout2.css,default.css

To fix, change the following line:

$combined_sources[] = (!$root_css_only ? preg_replace("/^".str_replace('/', '\/', $sf_relative_url_root.'/css/')."/i", '', $path) : $path);

to:

$combined_sources[] = ($root_css_only ? preg_replace("/^".str_replace('/', '\/', $sf_relative_url_root.'/css/')."/i", '', $path) : $path);

I tried to find Kiril Angov's contact, but couldn't find it.

Change History

09/08/07 14:29:56 changed by DrCore

  • summary changed from sfCombineFilter - problem with getCombinedStylesheets to [PATCH] sfCombineFilter - problem with getCombinedStylesheets.

Added patch to title.

12/20/07 15:19:26 changed by lking

  • owner changed from fabien to smeves.
  • component changed from plugins to sfCombineFilterPlugin.
  • qualification set to Unreviewed.
  • summary changed from [PATCH] sfCombineFilter - problem with getCombinedStylesheets to [sfCombineFilterPlugin][PATCH] problem with getCombinedStylesheets.