sfEmailValidator accepts invalid emails in strict mode

Hello,

There's a really nice validation code that was in a Linux Journal a few months ago.
Here's the code.

function CheckEmailStruct($email)

{

	$isValid = true;

	$atIndex = strrpos($email, "@");

	if (is_bool($atIndex) && !$atIndex)

	{

		$isValid = false;

	}

	else

	{

		$domain = substr($email, $atIndex+1);

		$local = substr($email, 0, $atIndex);

		$localLen = strlen($local);

		$domainLen = strlen($domain);

		if ($localLen < 1 || $localLen > 64)

		{

			// local part length exceeded

			$isValid = false;

		}

		else if ($domainLen < 1 || $domainLen > 255)

		{

			// domain part length exceeded

			$isValid = false;

		}

		else if ($local[0] == '.' || $local[$localLen-1] == '.')

		{

			// local part starts or ends with '.'

			$isValid = false;

		}

		else if (preg_match('/\\.\\./', $local))

		{

			// local part has two consecutive dots

			$isValid = false;

		}

		else if (!preg_match('/^[A-Za-z0-9\\-\\.]+$/', $domain))

		{

			// character not valid in domain part

			$isValid = false;

		}

		else if (preg_match('/\\.\\./', $domain))

		{

			// domain part has two consecutive dots

			$isValid = false;

		}

		else if (!preg_match('/^(\\\\.|[A-Za-z0-9!#%&`_=\\/$\'*+?^{}|~.-])+$/',

		str_replace("\\\\","",$local)))

		{

			// character not valid in local part unless

			// local part is quoted

			if (!preg_match('/^"(\\\\"|[^"])+"$/',

			str_replace("\\\\","",$local)))

			{

				$isValid = false;

			}

		}

		if ($isValid && !(checkdnsrr($domain,"MX") || checkdnsrr($domain,"A") || checkdnsrr($domain,"CNAME")))

		{

			// domain not found in DNS

			$isValid = false;

		}

	}

	return $isValid;

}

//and additionnal function for Windows Servers
if (!function_exists('checkdnsrr')) { //patch for windows OS servers, used in mail verification

	function checkdnsrr($host, $type = '') {

		if(!empty($host)) {

			if($type == '') $type = "MX";

			@exec("nslookup -type=$type $host", $output);

			while(list($k, $line) = each($output)) {

				if(eregi("^$host", $line)) {

					return true;

				}

			}

			return false;

		}

	}

}

I hope this can help to make a better sfEmailValidator function. achedeuzot

in r8831 and r8833

Re-opening ticket as regexes used as fixes are too restrictive.

Please review RFC 2822 as a source of characters legal in the local part of an email address. The regexes that were added as fixes are way too restrictive, and should be replaced with regexes that conform to RFC 2822. The regexes that were originally there were probably based on RFC 822, which has since been superceded by RFC 2822, although even the original regexes would not permit quoted whitespace, which is legal by RFC 822 and RFC 2822.

http://en.wikipedia.org/wiki/E-mail_address provides easy to read information showing what characters are legal in the local part of an email address, along with links to relevant RFCs.

(In [8835]) reverted r8833 (refs #2153)

reverted in r8838