Development

#2348 ([sfPropelNotificationPlugin] Remove variables in the schema)

You must first sign up to be able to contribute.

Ticket #2348 (new defect)

Opened 11 months ago

[sfPropelNotificationPlugin] Remove variables in the schema

Reported by: francois Assigned to: tristan
Priority: minor Milestone:
Component: sfPropelNotificationPlugin Version: 1.0.0
Keywords: Cc:
Qualification: Unreviewed

Description

The current implementation of the plugin forces the user to update the schema file bundled with the plugin - which contains ugly @FIXME@ tokens:

<table name="watch">
  <column name="id" type="INTEGER" required="true" primaryKey="true" autoIncrement="true" />
  <column name="user_id" type="INTEGER" required="true" />
  <column name="watch_type" type="VARCHAR" size="255" required="true" />
  <index name="watch_FKIndex2">
    <index-column name="user_id" />
  </index>
  <foreign-key foreignTable="@FIXME@" name="Rel_02" onDelete="">
    <reference local="user_id" foreign="@FIXME@" />
  </foreign-key>
</table>

This prevents any future update of the plugin, since the schema.xml is part of the source.

Two solutions are possible:

  • rename schema.xml to schema.sample.xml, and explain in the README file to copy this file under the project's config/ directory, rename it, and customize the tokens.
  • switch to a YAML schema using the Alternative Schema syntax, which allows user customization, and declare this second plugin as a dependence.