Development

#2551 ([PATCH] add image/logo/icon capabilities to sfFeed2Plugin)

You must first sign up to be able to contribute.

Ticket #2551 (closed enhancement: fixed)

Opened 8 months ago

Last modified 2 weeks ago

[PATCH] add image/logo/icon capabilities to sfFeed2Plugin

Reported by: FabianLange Assigned to: francois
Priority: major Milestone: plugins
Component: sfFeed2Plugin Version: 1.0.0
Keywords: rss atom feed icon image Cc:
Qualification: Ready for core team

Description

Both, Atom and RSS specifications have somehow support for images. both are pretty basic and some how crude, so I wrote an generic sfFeedImage that has enough information to serve both. Even some extra information to make its API a bit better. Use like this: 

  $feedImage = new sfFeedImage();
  $feedImage->setFavicon("http://domain/favicon.ico");
  $feedImage->setFaviconX(16);
  $feedImage->setFaviconY(16);
  $feedImage->setImage("http://domain/images/logo.gif");
  $feedImage->setImageX(158);
  $feedImage->setImageY(67);
  $this->feed->setImage($feedImage);

If set before link and title. The patch will use link and title of the feed for the image as well (as the rss spec suggests).

Attachments

sfFeed2Plugin_with_image.patch (17.2 kB) - added by FabianLange on 12/20/07 19:54:57.

Change History

11/30/07 08:41:55 changed by dwhittle

  • qualification changed from Unreviewed to Design decision.

12/20/07 17:06:51 changed by FabianLange

  • owner changed from francois to FabianLange.
  • qualification changed from Design decision to Unreviewed.

need to add unit tests

12/20/07 19:27:30 changed by FabianLange

  • owner changed from FabianLange to francois.
  • qualification changed from Unreviewed to Ready for core team.

patch now including unit tests

12/20/07 19:54:57 changed by FabianLange

  • attachment sfFeed2Plugin_with_image.patch added.

12/20/07 19:55:25 changed by FabianLange

updated patch to apply cleanly against trunk version

02/23/08 13:23:28 changed by fabien

Please, go ahead and commit it. Thanks.

06/23/08 06:16:30 changed by dwhittle

  • milestone set to plugins.

FabianLange?, Can you update the patch and commit?

06/23/08 11:41:23 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.

(In [9792]) added Image support to sfFeed2Plugin. Fixes #2551