Development

#2625 ([PATCH] sfMediaLibraryPlugin breaks with Adblock/Filterset.G)

You must first sign up to be able to contribute.

Ticket #2625 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH] sfMediaLibraryPlugin breaks with Adblock/Filterset.G

Reported by: notjosh Assigned to: francois
Priority: minor Milestone:
Component: sfMediaLibraryPlugin Version: 1.0.9
Keywords: Cc:
Qualification: Unreviewed

Description

I have Filterset.G installed, which is blocking the "advimage" plugin from loading. As such, it reverts back to the simple, inbuilt image tool (which is fine).

The problem if that the medialibrary Javascript tries to load the preview image into the image tool, which doesn't exist for the simple tool. I get the error: 

this.fileBrowserWin.showPreviewImage is not a function

If we wrap the call in a try/catch, then it continues with backward compatibility just fine, instead of getting the error.

Attachments

mediaLibraryJsError.patch (0.6 kB) - added by notjosh on 12/07/07 06:05:10.
Patch including the try/catch

Change History

12/07/07 06:05:10 changed by notjosh

  • attachment mediaLibraryJsError.patch added.

Patch including the try/catch

12/07/07 10:03:27 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

in r6351