Development

#2628 ([PATCH] incorrect use of a block element inside a inline element)

You must first sign up to be able to contribute.

Ticket #2628 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

[PATCH] incorrect use of a block element inside a inline element

Reported by: Pascal.Borreli Assigned to: francois
Priority: minor Milestone:
Component: sfSimpleForumPlugin Version:
Keywords: forum inline block sfSimpleForumPlugin Cc:
Qualification: Unreviewed

Description

Hi,

In main forum view, _forum.php there is : 

<span class="forum_description"><?php echo simple_format_text($forum->getDescription()) ?></span>

which generate : 

<span class="forum_description"><p>Everybody is foo here</p></span>

As you can see simple_format_text text helper method render the <p> enclosed tag.

I've included a patch which removes the span and put the appropriate class on paragraph block element in order to generate : 

<p class="forum_description">Everybody is foo here</p>

Cheers,
[MA]Pascal
SQLI Oujda/Maroc

Attachments

_forum.php.patch (0.9 kB) - added by Pascal.Borreli on 12/07/07 14:35:18.
PATCH for _form.php in plugins/sfSimpleForumPlugin/trunk/modules/sfSimpleForum/templates/_forum.php

Change History

12/07/07 14:35:18 changed by Pascal.Borreli

  • attachment _forum.php.patch added.

PATCH for _form.php in plugins/sfSimpleForumPlugin/trunk/modules/sfSimpleForum/templates/_forum.php

12/20/07 19:15:00 changed by Pascal.Borreli

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [6629] & [6630]