Development

#2648 (sfPropelPager doesn't allow unlimited rows per page)

You must first sign up to be able to contribute.

Ticket #2648 (closed defect: fixed)

Opened 1 year ago

Last modified 7 months ago

sfPropelPager doesn't allow unlimited rows per page

Reported by: Rihad.Haciyev Assigned to: FabianLange
Priority: minor Milestone: 1.0.14
Component: other Version: 1.0.9
Keywords: Cc:
Qualification: Accepted

Description

Although sfPager and sfPropelPager special-case maxPerPage == 0 for some purpose, setting it to zero doesn't work: 

$pager = new sfPropelPager('Foo', 0);

Notice: Undefined offset: -1 in /usr/local/share/pear/symfony/addon/sfPager.class.php on line 89

Attachments

sfPager.class.patch (419 bytes) - added by FabianLange on 04/29/08 09:01:41.
this seems to be it. can't test it right now.

Change History

04/29/08 08:51:45 changed by FabianLange

  • owner changed from fabien to FabianLange.
  • status changed from new to assigned.
  • qualification changed from Unreviewed to Accepted.
  • milestone set to 1.0.14.

oh didnt notice that feature. He is right doesn't work. I would like to see that fixed in 1.0.14. I think I can provide a patch soon. (1.1 has the same flaw. will fix it there as well)

04/29/08 09:01:41 changed by FabianLange

  • attachment sfPager.class.patch added.

this seems to be it. can't test it right now.

04/29/08 19:03:32 changed by FabianLange

  • status changed from assigned to closed.
  • resolution set to fixed.

okay, your issue was resolved in symfony 1.0.11 and above already. But the fix was incomplete. I tweaked it in r8680 so that now getLastIndice() will return the correct result.

04/29/08 19:05:49 changed by FabianLange

(In [8681]) fixed display of last index. therefore setPage should accept 0 as valid page. (refs #2648)