Development

#2824 ([PATCH] Remove prototype dependency in admin_double_list helper and js)

You must first sign up to be able to contribute.

Ticket #2824 (closed enhancement: fixed)

Opened 11 months ago

Last modified 8 months ago

[PATCH] Remove prototype dependency in admin_double_list helper and js

Reported by: jerome Assigned to: jerome
Priority: minor Milestone: 1.1.0 beta3
Component: helpers Version: 1.0.11
Keywords: admin_double_list Cc:
Qualification: Design decision

Description

All is in the title and patches.

Attachments

ObjectAdminHelper.php.patch (460 bytes) - added by jerome on 01/22/08 16:27:24.
double_list.js (0.9 kB) - added by jerome on 01/22/08 16:28:15.
double_list.js.patch (419 bytes) - added by jerome on 01/22/08 16:29:15.

Change History

01/22/08 16:27:24 changed by jerome

  • attachment ObjectAdminHelper.php.patch added.

01/22/08 16:28:15 changed by jerome

  • attachment double_list.js added.

01/22/08 16:29:15 changed by jerome

  • attachment double_list.js.patch added.

01/22/08 16:29:37 changed by jerome

  • version deleted.
  • milestone set to 1.0.12.

02/14/08 23:27:56 changed by jerome

  • version set to 1.0.11.
  • summary changed from Remove prototype dependency in admin_double_list helper and js to [PATCH] Remove prototype dependency in admin_double_list helper and js.

03/10/08 22:14:05 changed by FabianLange

  • owner changed from fabien to jerome.
  • qualification changed from Unreviewed to Design decision.
  • milestone deleted.

that patch is not complete. The new lines 110 and 111 od that ObjectAdmin? Helper also use the $ shortcut. 

    submit_image_tag(sfConfig::get('sf_admin_web_dir').'/images/next.png', "style=\"border: 0\" onclick=\"double_list_move(document.getElementById('{$name1}'), document.getElementById('{$name2}')); return false;\""),
    submit_image_tag(sfConfig::get('sf_admin_web_dir').'/images/previous.png', "style=\"border: 0\" onclick=\"double_list_move(document.getElementById('{$name2}'), document.getElementById('{$name1}')); return false;\""),

should do the trick but please validate this again.

I am unsure if this can be submitted against 1.0 at all as somebody might rely by chance on this helper including protoype. I propose doing this only in symfony 1.1

03/10/08 23:07:40 changed by dwhittle

Please see the version of this file in my 1.1 branch, it has been tested.

04/05/08 20:43:40 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.

(In [8323]) removed prototype dependency from double_list javascript in ObjectAdmin?. closes #2824

04/05/08 20:46:05 changed by FabianLange

  • milestone set to 1.1.0 beta3.

I decided for now to only apply this to symfony 1.1. I am still unsure if it would break people who were relying on prototype being included by this. And as the "enhancement" is just the exclusion of prototype I consider this okay for being only in 1.1 If somebody proves me that customers could not rely on prototype being included we can apply this to 1.0 as well, its a small patch (I actually improved the object helper a bit more)

04/06/08 10:01:33 changed by fabien

We can't apply it to 1.0. As you said, if some projects realy on the prototype registration side effect, we can't break their apps.