Development

#2890 ([PATCH] sfPropelActAsTaggablePlugin)

You must first sign up to be able to contribute.

Ticket #2890 (closed enhancement: fixed)

Opened 10 months ago

Last modified 10 months ago

[PATCH] sfPropelActAsTaggablePlugin

Reported by: forkmantis Assigned to: xavier
Priority: minor Milestone:
Component: sfPropelActAsTaggablePlugin Version: 1.0.10
Keywords: Cc:
Qualification: Accepted

Description

This patch extends sfPropelActAsTaggableBehavior::addTag() to accept strings using linebreaks as a delimeter in addition to commas. This allows a textarea to accept one tag per line as valid input.

Attachments

sfPropelActAsTaggableToolkit.class.php.patch (0.7 kB) - added by forkmantis on 02/06/08 18:06:39.
Replacement patch attempting to address issue raised by Markus.Staab

Change History

02/06/08 17:31:57 changed by Markus.Staab

patch missing that line ending can be on of those: 

\n
\r\n
\r

02/06/08 17:53:22 changed by forkmantis

Assuming that I address that issue, does this seem like a reasonable feature?

I suppose once the array is created we could check for empty strings and remove them. In addition to addressing lines ending with a linebreak, we will also address lines ending in ",", or lines containing "".

02/06/08 18:06:39 changed by forkmantis

  • attachment sfPropelActAsTaggableToolkit.class.php.patch added.

Replacement patch attempting to address issue raised by Markus.Staab

02/07/08 16:06:43 changed by xavier

  • status changed from new to closed.
  • resolution set to fixed.
  • qualification changed from Unreviewed to Accepted.

fixed in [7390]