Development

#3065 (Etag Feature broken)

You must first sign up to be able to contribute.

Ticket #3065 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Etag Feature broken

Reported by: Markus.Staab Assigned to: fabien
Priority: major Milestone: 1.0.12
Component: cache Version: 1.0.10
Keywords: etag Cc:
Qualification: Accepted

Description

since the etag is send enclosed in doublequotes, the etag feature is broken! The browser sends the etag back to the server, enclosed in doublequotes, and so the if case will never match, because of the missing "

is 

$this->response->setHttpHeader('ETag', '"'.$etag.'"');
if ($this->request->getHttpHeader('IF_NONE_MATCH') == $etag)

should be 

$this->response->setHttpHeader('ETag', '"'.$etag.'"');
if ($this->request->getHttpHeader('IF_NONE_MATCH') == '"'.$etag.'"')

Change History

03/07/08 21:33:03 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 1.0.12.

You are right. fixed in r7769 for 1.0 and in r7770 for 1.0.

03/07/08 21:50:46 changed by FabianLange

okay besides that i see that this might be a bit troublesome because i get in my mod_deflate scenario a -gzip appended. Might be something worth looking into in 1.1

03/08/08 15:17:57 changed by Markus.Staab

  • qualification changed from Unreviewed to Accepted.

this feature should better be covered by a unit test... also the Last-Modified feature..