Development

#3218 (Create a way to change sfWebDebug::decorateContentWithDebug())

You must first sign up to be able to contribute.

Ticket #3218 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

Create a way to change sfWebDebug::decorateContentWithDebug()

Reported by: dwhittle Assigned to: fabien
Priority: minor Milestone:
Component: other Version: 1.1.0 DEV
Keywords: Cc:
Qualification: Unreviewed

Description

As of now there is no way to extend or change the debug toolbar sfWebDebug::decorateContentWithDebug(). Can we change this to not be static and set sf_web_debug in sf_context->get('sf_web_debug')->decorateContentWithDebug() or a better solution.

(I have done this in my branch and can merge if you think it is a good idea).

Change History

03/27/08 07:34:30 changed by fabien

We need to find another way as I don't want to couple context with everything else. I think it would be better to move the decorateContentWithDebug in sfViewCacheManager as all the calls are now from this class.

03/27/08 09:36:21 changed by dwhittle

I agree, my patch is meant as a temporary hack. This stems from trying to rewrite the web debug toolbar, the only problem is the inability to extend decorateContentWithDebug. I would prefer to keep the method with the debug logger, and not the view cache manager as it seems like that would decouple the web toolbar functionality.. Maybe an event to filter the content?

04/22/08 22:57:07 changed by dwhittle

Can we change decorateContentWithDebug to a filter event? It removes the sfContext dependency and allows multiple listeners..

05/15/08 18:46:55 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [8983]) added a view.cache.filter_content event to decouple the sfViewCacheManager and the sfWebDebug class (closes #3218)