Development

#3308 ([JavascriptHelper.php sortable_element()] I don't want to use AJAX)

You must first sign up to be able to contribute.

Ticket #3308 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

[JavascriptHelper.php sortable_element()] I don't want to use AJAX

Reported by: jug Assigned to: FabianLange
Priority: minor Milestone: 1.1.0 beta3
Component: helpers Version: 1.0.12
Keywords: Cc:
Qualification: Accepted

Description

Hi,

I want to have a sortable list, but without any AJAX interaction when ordering. I had to do this little modification in the sortable_element function :

If no 'url' option is passed... No 'onUpdate' function !

See attached diff file.

Regards,

Julien

Attachments

JavascriptHelper.php.diff (444 bytes) - added by jug on 04/10/08 16:57:52.

Change History

04/10/08 16:57:52 changed by jug

  • attachment JavascriptHelper.php.diff added.

04/10/08 17:38:45 changed by FabianLange

  • owner changed from fabien to FabianLange.
  • status changed from new to assigned.

for me that looks okay, let me quickly check what happens at the moment if no url is set.

04/10/08 17:47:21 changed by FabianLange

  • qualification changed from Unreviewed to Accepted.
  • milestone set to 1.1.0 beta3.

okay without url it currently breaks ugly. 

Notice: Undefined index: url in C:\test\lib\symfony\helper\JavascriptHelper.php on line 457

I think its a nice addition. I will put it in for 1.1

04/10/08 18:02:51 changed by FabianLange

  • status changed from assigned to closed.
  • resolution set to fixed.

closed in r8395. I have not changed sf 1.0 code right now. I think you are aware of workarounds like providing a "onUpdate" option like 

"onUpdate" => "function(){}"