Development

#3478 (Error Reporting value for default test environment incorrect)

You must first sign up to be able to contribute.

Ticket #3478 (closed defect: fixed)

Opened 3 months ago

Last modified 3 weeks ago

Error Reporting value for default test environment incorrect

Reported by: subzero2000 Assigned to: fabien
Priority: minor Milestone: 1.1.0
Component: configuration Version:
Keywords: Cc:
Qualification: Unreviewed

Description

The value being calculated for error reporting by default in the test environment is incorrect. The following was done under PHP 5.2.5:

dev environment value: $ php -r 'echo (E_ALL | E_STRICT) . "\n";' 8191

test environment value: $ php -r 'echo (E_ALL | E_STRICT & ~E_NOTICE) . "\n";' 8191

As you can see, both calculations yield the same result, even though clearly they are not intended to do so. However, if you adjust them as follows:

dev environment value: $ php -r 'echo (E_ALL | E_STRICT) . "\n";' 8191

test environment value: $ php -r 'echo ((E_ALL | E_STRICT) & ~E_NOTICE) . "\n";' 8183

Then it becomes evident that the values are different like they are supposed to be.

Therefore, I propose that everywhere in code that E_ALL | E_STRICT & ~E_NOTICE is being used, that (E_ALL | E_STRICT) & ~E_NOTICE be used in it's place.

Currently, in the 1.0 branch, this is in data/skeleton/app/app/config/settings.yml on line 15, and in the trunk is in lib/symfony/task/generator/skeleton/app/app/config/settings.yml on line 16.

Change History

06/23/08 07:05:55 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

06/23/08 09:21:58 changed by fabien

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to 1.1.0 FINAL.

06/23/08 11:48:21 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [9793]) fixed error reporting value for the test environment and added a migration task (closes #3478)

06/29/08 23:34:03 changed by FabianLange

  • milestone changed from 1.1.0 FINAL to 1.1.0.