Development

#3497 (Remove ini_get() call in sfRichTextEditorFCK.class.php)

You must first sign up to be able to contribute.

Ticket #3497 (closed enhancement: fixed)

Opened 3 days ago

Last modified 3 days ago

Remove ini_get() call in sfRichTextEditorFCK.class.php

Reported by: jcoby Assigned to: FabianLange
Priority: minor Milestone: 1.1.0 RC2
Component: helpers Version: 1.0.14
Keywords: Cc:
Qualification: Accepted

Description

the call to ini_get() in sfRichTextEditorFCK is not needed as error_reporting() will return the previous error level (see http://us.php.net/error_reporting).

Here is a patch against 1.0.13

Index: lib/helper/sfRichTextEditorFCK.class.php
===================================================================
--- lib/helper/sfRichTextEditorFCK.class.php	(revision 8593)
+++ lib/helper/sfRichTextEditorFCK.class.php	(working copy)
@@ -44,8 +44,7 @@
 
     // FCKEditor.php class is written with backward compatibility of PHP4.
     // This reportings are to turn off errors with public properties and already declared constructor
-    $error_reporting = ini_get('error_reporting');
-    error_reporting(E_ALL);
+    $error_reporting = error_reporting(E_ALL);
 
     require_once(sfConfig::get('sf_web_dir').DIRECTORY_SEPARATOR.$php_file);

Attachments

#3497_branche_1.1.patch (0.7 kB) - added by Pascal.Borreli on 05/08/08 17:09:05.
patch for branch 1.1

Change History

05/08/08 17:09:05 changed by Pascal.Borreli

  • attachment #3497_branche_1.1.patch added.

patch for branch 1.1

05/09/08 09:01:04 changed by FabianLange

  • owner changed from fabien to FabianLange.
  • status changed from new to assigned.
  • qualification changed from Unreviewed to Accepted.
  • milestone set to 1.1.0 RC2.

05/09/08 09:11:14 changed by FabianLange

(in 8872) included code cleanup from jcoby. thanks. closes #3497

05/09/08 09:11:19 changed by FabianLange

  • status changed from assigned to closed.
  • resolution set to fixed.