Development

#429 (lack of semicolon in autogenerated template code triggers error notices in Eclipse)

You must first sign up to be able to contribute.

Ticket #429 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

lack of semicolon in autogenerated template code triggers error notices in Eclipse

Reported by: anonymous Assigned to:
Priority: minor Milestone:
Component: Version:
Keywords: Cc:
Qualification:

Description

The code auto-generated by sfPropelAdmin includes snippets such as: 

<?php endforeach ?>

and 

<?php endif ?>

Using the PHP Eclipse plugin, the internal PHP parser flags this as a parse error because there the closing semicolon is missing. It would be great if the auto-generated code could render with the semicolon like this: 

<?php endforeach; ?>

Attachments

error notices.png (65.7 kB) - added by matt mcneil on 04/14/06 04:28:08.

Change History

04/14/06 04:28:08 changed by matt mcneil

  • attachment error notices.png added.

04/14/06 08:14:47 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

fixed in r1205.

04/14/06 19:50:08 changed by matt_m

  • status changed from closed to reopened.
  • resolution deleted.

Thanks for attending to this so quickly and for your excellent work throughout this project! I did find, however, a few other instances of this issue that remain: 

$ egrep -Hnre 'endif \?>|endforeach \?>' lib/ data/ | grep -v svn
lib/symfony/helper/CacheHelper.php:27:<?php endif ?>
data/symfony/data/exception.php:37:  <?php endif ?>
data/symfony/data/exception.txt:8:<?php endforeach ?>
data/symfony/data/exception.txt:9:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:99:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:100:<?php endforeach ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:101:<?php endforeach ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:127:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:145:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:169:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:173:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:174:<?php endforeach ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:175:<?php endforeach ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:202:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:225:<?php endif ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:227:<?php endforeach ?>
data/symfony/generator/sfPropelAdmin/default/template/actions/actions.class.php:228:<?php endif ?>
data/symfony/generator/sfPropelCrud/default/template/actions/actions.class.php:68:<?php endif ?>
data/symfony/generator/sfPropelCrud/default/template/actions/actions.class.php:69:<?php endforeach ?>
data/symfony/generator/sfPropelCrud/default/template/templates/editSuccess.php:7:<?php endforeach ?>
data/symfony/generator/sfPropelCrud/default/template/templates/editSuccess.php:15:  <th><?php echo sfInflector::humanize(sfInflector::underscore($column->getPhpName())) ?><?php if ($column->isNotNull()): ?>*<?php endif ?>:</th>
data/symfony/generator/sfPropelCrud/default/template/templates/editSuccess.php:18:<?php endforeach ?>
data/symfony/generator/sfPropelCrud/default/template/templates/listSuccess.php:8:<?php endforeach ?>
data/symfony/generator/sfPropelCrud/default/template/templates/listSuccess.php:19:  <?php endif ?>
data/symfony/generator/sfPropelCrud/default/template/templates/listSuccess.php:20:<?php endforeach ?>
data/symfony/generator/sfPropelCrud/default/template/templates/showSuccess.php:8:<?php endforeach ?>

04/19/06 13:06:47 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.

fixed in r1228.