sfFillInFormFilter omits default values

I personally consider this expected behaviour, which might seem odd to you, but here goes....

If you want to use values shown in the template, don't load the fillin filter, if you wnat to use things from the request to fill in your form, then load the fillin filter.

If you want to use a bit from both, then perhaps ticket #573 mihgt be of interest to you, where you can specifically stop the fillin filter from filling in a certain field.

Does this help? Please close this ticket if you are happy with this comment

I haven't caught the point. I want to use values from the request, but only if there is any chance, the values make sense (the form was submitted). How can I specify default values, when the form hasn't been submitted yet? I would expect the sfFillInFormFilter to take action only in case a user submits the form.

I agree with anonymous here Ian, the fillInFilter should only populate form fields IF the request variable for that field exists. If it does not exist and filter is enabled, we must assume that the form has never been submitted and thus populate the field with the default value.

yeah, you're right, I'll fix this :)

try this...

Index: lib/filter/sfFillInFormFilter.class.php
===================================================================
--- lib/filter/sfFillInFormFilter.class.php     (revision 1389)
+++ lib/filter/sfFillInFormFilter.class.php     (working copy)
@@ -62,7 +62,7 @@
       foreach($xpath->query($query, $form) as $element)
       {
         // skip fields specified in the 'skip_fields' attribute
-        if ($request->hasParameter($element->getAttribute('name')) && in_array($element->getAttribute('name'), $skip_fields))
+        if (!($request->hasParameter($element->getAttribute('name'))) || in_array($element->getAttribute('name'), $skip_fields))
         {
           continue;
         }
@@ -145,4 +145,4 @@
   }
 }

-?>
\ No newline at end of file
+?>

this has been checked into my branch in r1390

If I try:

actions.class.php

  public function executeIndex()
  {
  }

  public function handleErrorIndex()
  {
    return sfView::SUCCESS;
  }

validate/index.yml

methods:
  post: [...]

fillin:
  activate: on

templates/indexSuccess.php

<?php echo form_tag('test/index') ?>
<?php echo input_tag('test', 2) ?>
<?php echo checkbox_tag('test1', '1', true) ?>
<?php echo submit_tag() ?>
</form>

It works as expected. The first time I call the index page (GET), the checkbox is checked.