Development

#520 ([PATCH] sfFeed addItemFromArray() problem)

You must first sign up to be able to contribute.

Ticket #520 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] sfFeed addItemFromArray() problem

Reported by: Xavier Lacot <xavier@lacot.org> Assigned to:
Priority: minor Milestone: 0.6.3
Component: Version: 0.7.X
Keywords: sfFeed Cc: xavier@lacot.org
Qualification:

Description

addItemFromArray() method, used for xml feeds generation, from the sfFeed class doesn't repect the sfFeedItem prototype. Moreover. several attributes were required, I added checks before setting the item properties.

Please find attached a corrective patch.

cheers,

Attachments

sfFeedPatch.patch (2.4 kB) - added by Xavier Lacot <xavier@lacot.org> on 05/09/06 15:54:46.
patch for sfFeed.class.php
sfFeed.diff (2.7 kB) - added by joey.cai@gmail.com on 05/26/06 09:23:32.
Patch agains r1327 that fixes typos.

Change History

05/09/06 15:54:46 changed by Xavier Lacot <xavier@lacot.org>

  • attachment sfFeedPatch.patch added.

patch for sfFeed.class.php

05/09/06 15:56:40 changed by Xavier Lacot <xavier@lacot.org>

  • summary changed from sfFeed addItemFromArray() problem to [PATCH] sfFeed addItemFromArray() problem.

05/09/06 16:14:29 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 0.6.3.

in r1327.

05/26/06 09:23:32 changed by joey.cai@gmail.com

  • attachment sfFeed.diff added.

Patch agains r1327 that fixes typos.

05/26/06 09:24:34 changed by joey.cai@gmail.com

  • status changed from closed to reopened.
  • resolution deleted.

The original patch wasn't applied correctly. Typos still exist. I've attached another patch.Please have a look at it.

05/26/06 09:57:07 changed by Xavier Lacot <xavier@lacot.org>

Or, cleaner and more meaningful, change the names of all the methods in sfFeedItem from "feed" to "item" (for instance, setFeedTitle() should be setItemTitle())

06/16/06 09:46:47 changed by fabien

  • milestone changed from 0.6.3 to 1.0.0.

06/16/06 17:32:16 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from 0.6.4 to 0.6.3.

in r1469