[PATCH] Add support to create <optgroup> tags from nested arrays in options_for_select()

sorry the code formatting got all screwed up =/

Updated the function to take into account include_custom and include_blank. I had to unset these vars before creating the optgroup or else it would add them underneath each optgroup tag.

function options_for_select($options = array(), $selected = '', $html_options = array())
{
  $html_options = _parse_attributes($html_options);

  if (is_array($selected))
  {
    $valid = array_values($selected);
    $valid = array_map('strval', $valid);
  }

  $html = '';

  if (isset($html_options['include_custom']))
  {
    $html .= content_tag('option', $html_options['include_custom'], array('value' => ''))."\n";
  }
  else if (isset($html_options['include_blank']))
  {
    $html .= content_tag('option', '', array('value' => ''))."\n";
  }

  foreach ($options as $key => $value)
  {
  	if (is_array($value))
  	{
  	  $optgroup_html_options = $html_options;
  	  unset($optgroup_html_options['include_custom']);
  	  unset($optgroup_html_options['include_blank']);
  	  $html .= content_tag('optgroup', options_for_select($value, $selected, $optgroup_html_options), array('label' => $key))."\n";
  	}
  	else 
  	{
      $option_options = array('value' => $key);
    	
      if (
          isset($selected)
          &&
          (is_array($selected) && in_array(strval($key), $valid, true))
          ||
          (strval($key) == strval($selected))
         )
      {
        $option_options['selected'] = 'selected';
      }

      $html .= content_tag('option', $value, $option_options)."\n";    	
  	}
  }

  return $html;
}

Sample Code to test:

<?php echo select_tag('whatever', options_for_select(array(1 => 'bob', 2 => 'sue', 'group A' => array(4 => 'bill', 5 => 'jerry'), 'Group B' => array(7 => 'john', 8 => 'smith')))); ?>

Fixed in r1420

in r1432