Development

#961 (admin generator - VARCHAR size wrong)

You must first sign up to be able to contribute.

Ticket #961 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

admin generator - VARCHAR size wrong

Reported by: skr68 Assigned to:
Priority: minor Milestone: 1.0.0
Component: Version: 0.7.X
Keywords: Cc:
Qualification:

Description

I've dived into sfPropelCrudGenerator and found that $column->getSize() always returns an empty value.

$size = ($column->getSize() > 20 ? ($column->getSize() < 80 ? $column->getSize() : 80) : 20);

Change History

09/28/06 14:49:55 changed by jphipps@madcreek.com

This is a duplicate of ticket #63 and #379 and is a Propel bug (http://propel.phpdb.org/trac/ticket/235) that the Propel folks have yet to fix.

It's certainly up to Fabien (he's rejected the bug twice already), but it seems to me that we need to patch this ourselves (I patch it in Symfony trunk every time I update) or stop depending on Propel to report the correct size limits to sfPropelCrudGenerator -- for instance, we could add a 'size:' property to the fields in generator.yml. But it seems like it would be simpler to just patch the Propel code in Symfony trunk.

09/28/06 14:56:31 changed by fabien

  • milestone set to 1.0.0.

12/16/06 18:17:26 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [3058]) fixed admin generator - VARCHAR size wrong (closes #961)